In the Linux kernel, the following vulnerability has been resolved: mm/gup: recheck the PUD...
🔗 CVE IDs covered (1)
📋 Description
In the Linux kernel, the following vulnerability has been resolved:
mm/gup: recheck the PUD under PTL in follow_pud_mask()
follow_pud_mask() reads the PUD without a lock. If it is a leaf, it takes the lock and calls follow_huge_pud(), which reads the entry again, but only tests whether it is present.
A leaf can be zapped concurrently and a page fault can fill the empty entry with a page table.
This currently only applies when device-dax makes use of PUD entries, and the fault after e.g., MADV_DONTNEED would find THPs to be disabled.
That requires a sequence like
- Fault in the PUD
- Disable THP
- Have GUP race against concurrent MADV_DONTNEED + refault
Which is rather unlikely to happen in practice, which is why we never received a report about such a problem.
Before commit 1b1676180246 ("mm/gup: handle huge pud for follow_pud_mask()"), we performed that check in follow_devmap_pud() by testing for pud_devmap().
Let's fix it by just structuring follow_pud_mask() similar to follow_pmd_mask(), minus protnone stuff that does not apply and minus FOLL_SPLIT_PMD handling. That makes it much easier to spot any such inconsistencies.
Perform the pud_bad() check early in follow_pmd_mask() and just forward the PUD value. We can drop the pud_present() check in follow_huge_pud(), just like we have in follow_huge_pmd().
Even though we are performing more changes than strictly necessary, the fix should be easy to backport.
🔗 References (5)
- https://nvd.nist.gov/vuln/detail/CVE-2026-99664
- https://git.kernel.org/stable/c/79cb51d538abc459f74e046d27797d36b133ce0e
- https://git.kernel.org/stable/c/9eaedd598cd25eb0e18958e2456153a4c1f3db03
- https://git.kernel.org/stable/c/da57b6bce646946c083a48df644d43bb9d011f5f
- https://github.com/advisories/GHSA-xh4m-hvjw-jx9j