Effect: Cookie attribute injection via domain, path, and name fields in @effect/platform makeCookie()
🔗 CVE IDs covered (1)
📋 Description
Impact
The name, domain, and path fields of makeCookie() were validated with a regex that allows ;, the attribute separator in Set-Cookie headers. Because serializeCookie() writes those fields verbatim, a caller who passes untrusted input into any of them can append arbitrary attributes to the header.
For example, a domain of "legit.com; Domain=.parent.tld" serializes to session=token; Domain=legit.com; Domain=.parent.tld. RFC 6265 §5.3 takes the last occurrence, so the injected domain wins and the cookie widens to the parent domain. The same trick sets SameSite=None or Max-Age when the caller has not set those options itself.
The value field is unaffected: it passes through encodeURIComponent, which encodes ;. CR and LF are rejected by the existing regex, so header splitting is not possible.
Patches
Fixed in #6763 (v4) and #6765 (v3): the shared regex is split into per-field validators that reject ;, and serializeCookie() now validates before writing the header.
Workarounds
Do not pass user input into name, domain, or path; set them from application constants.
🎯 Affected products2
- npm/@effect/platform:>= 0.1.0, < 0.97.1
- npm/effect:>= 4.0.0-beta.0, < 4.0.0-beta.103
🔗 References (9)
- https://github.com/Effect-TS/effect/security/advisories/GHSA-chp3-j5qr-2vfr
- https://nvd.nist.gov/vuln/detail/CVE-2026-115779
- https://github.com/Effect-TS/effect/pull/6763
- https://github.com/Effect-TS/effect/pull/6765
- https://github.com/Effect-TS/effect/commit/4a57af24011db1d66e947289d2f7ffc2074696d2
- https://github.com/Effect-TS/effect/commit/5859b373b9be04d5037a594196b4743ad80379bd
- https://github.com/Effect-TS/effect/releases/tag/@effect/[email protected]
- https://github.com/Effect-TS/effect/releases/tag/[email protected]
- https://github.com/advisories/GHSA-chp3-j5qr-2vfr